Skip to content

Make it clear that the msg argument to assertRaises is keyword-only.#9670

Merged
benjaminp merged 1 commit into
python:masterfrom
benjaminp:assert-raises-keyword
Oct 2, 2018
Merged

Make it clear that the msg argument to assertRaises is keyword-only.#9670
benjaminp merged 1 commit into
python:masterfrom
benjaminp:assert-raises-keyword

Conversation

@benjaminp

@benjaminp benjaminp commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Oct 2, 2018
@benjaminp benjaminp merged commit be4e5b8 into python:master Oct 2, 2018
@miss-islington

miss-islington commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@benjaminp benjaminp deleted the assert-raises-keyword branch October 2, 2018 05:18
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2018
@benjaminp @miss-islington
Make it clear that the msg argument to assertRaises is keyword-only. (p…
0d032a8 
…ythonGH-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot

bedevere-bot commented Oct 2, 2018

Copy link
Copy Markdown

GH-9671 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2018
@benjaminp @miss-islington
Make it clear that the msg argument to assertRaises is keyword-only. (p…
944c2e1 
…ythonGH-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot

bedevere-bot commented Oct 2, 2018

Copy link
Copy Markdown

GH-9672 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Oct 2, 2018
@miss-islington @benjaminp
Make it clear that the msg argument to assertRaises is keyword-only. (G…
484c899 
…H-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Oct 2, 2018
@miss-islington @benjaminp
Make it clear that the msg argument to assertRaises is keyword-only. (G…
58376c6 
…H-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@serhiy-storchaka

serhiy-storchaka commented Oct 2, 2018

Copy link
Copy Markdown
Member

See also assertRaisesRegex(), assertWarns() and assertWarnsRegex(). And maybe other methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminp @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni